Hi,

On Tue, Mar 24, 2020 at 11:42:02AM +0100, Tom van Leeuwen wrote:
> When an mbedTLS session is moved in move_session(), the contents of the
> the tls_session is copied to the new session and the old session is
> reinitialized. This tls_session contains, amongst other things, an
> mbedtls_ssl_config and bio_ctx structure. However, the mbedtls context has
> internal pointers to the mbedtls_ssl_config and bio_ctx. When the session
> is moved, these internal pointers point to the reinitialized session.
> Since there is no public method to update these internal pointers, this
> patch allocates the mbedtls_ssl_config and bio_ctx on the heap and stores
> the pointers in the tls_session instead.
> 
> diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c
> index 0f0b035b..4f194ad7 100644
> --- a/src/openvpn/ssl_mbedtls.c
> +++ b/src/openvpn/ssl_mbedtls.c
> @@ -1036,21 +1036,22 @@ key_state_ssl_init(struct key_state_ssl *ks_ssl,
>      CLEAR(*ks_ssl);
>  
>      /* Initialise SSL config */

Without speaking of the merits of the patch it self, it got destroyed
on the way - all leading spaces got turned int "alt-space" (\xa0), so
it won't apply.

Can you re-send using "git send-email"?  This usually nicely manages
to avoid all classic "mail client breaks patch" problems.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to