Hi,
On Mon, Mar 30, 2020 at 8:59 AM Paolo Cerrito <[email protected]> wrote:
> 1) so remote was set to the maxlenght of ipv6 address defined into
> arpa/inet.h + 1 for string terminator
>
> 2) I refactored the call to get_env to take first ipv6 address, then
> only if it is NULL, i make a call for ipv4
> ---
> src/plugins/auth-pam/auth-pam.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/plugins/auth-pam/auth-pam.c
> b/src/plugins/auth-pam/auth-pam.c
> index ae0d495a..cd91a33c 100644
> --- a/src/plugins/auth-pam/auth-pam.c
> +++ b/src/plugins/auth-pam/auth-pam.c
> @@ -48,7 +48,7 @@
> #include <signal.h>
> #include <syslog.h>
> #include "utils.h"
> -
> +#include <arpa/inet.h>
#include <openvpn-plugin.h>
>
> #define DEBUG(verb) ((verb) >= 4)
> @@ -115,7 +115,7 @@ struct user_pass {
> char password[128];
> char common_name[128];
> char response[128];
> - char remote[46]; //46 as ipv6 form n:n:n:n:n:n:d.d.d.d and +
> terminator \0
> + char remote[INET6_ADDRSTRLEN+1]; //INET6_ADDRSTRLEN is the lenght of
> ipv6 + terminator \0
>
INET6_ADDRSTRLEN = 46 already includes space for nul termination
More importantly, you have to provide a single updated patch
preferably with version indicated in the subject and sent out with
--in-reply-to <msgid> referring to the previous version.
Submitting incremental pieces of fixup commits doesn't help. And please
wait for review before making changes unless correcting a critical error.
Thanks,
Selva
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
