Acked-by: Gert Doering <[email protected]>
I won't claim to understand management, but the patch does what it
says, and it does so in the same way as querying for >PASSWORD is
done. Selva understands management way better than I do, so if he
says this is needed, and the code is in line with what we currently
have (manage.c, management_query_user_pass(), management_hold(),
management_query_multiline()...) and does not look like "mem leak"
or "overflow" - which it doesn't - good enough for me.
The code *looks* as if a reference to "out" is going out of scope,
but that one is allocated in &gc, so it's fine. Just hard to read.
These functions could do with a bit of C99 modernizing, getting
rid of extra nesting levels that are just there to enable local
variables... but that's for a different round of refactoring.
Your patch has been applied to the master branch.
commit 93ba6ccddafcc87f336f50dadde144ea4f6178ad
Author: Selva Nair
Date: Thu Feb 20 22:00:28 2020 -0500
Persist management-query-remote and proxy prompts
Signed-off-by: Selva Nair <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg19497.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
