On Mon, 2020-06-22 at 18:23 +0200, Gert Doering wrote: > Hi, > > On Sun, Jun 21, 2020 at 08:10:34AM -0700, James Bottomley wrote: > > > Arne, James, can we converge on something here? > > > > Could someone just test the proposed updated v6 patch on a Mac? > > > > https://sourceforge.net/p/openvpn/mailman/message/37031113/ > > Took Arne and me half a day ("the macos build slave did not have > cmocka, and it went downhill from there") but I can now confirm that > it works and passes the tests. > > This is on a Mojave MacMini with "brew" openssl 1.1.1c and your patch > "v6": > > Making check in engine-key > /Applications/Xcode.app/Contents/Developer/usr/bin/make libtestengin > e.la > ... > /bin/sh ../../../libtool --tag=CC --mode=link gcc -I/usr/local/Cel > lar/openssl@1.1/1.1.1c/include -I../../../../openvpn.git/include > -I/usr/local/Cellar/cmocka/1.1.5/include -I -I -Wall -Wno-unused- > parameter -Wno-unused-function -g -O2 -std=c99 -L/usr/local/Cellar/op > enssl@1.1/1.1.1c/lib -lcrypto -lssl - > L/usr/local/Cellar/cmocka/1.1.5/lib -lcmocka -rpath /lib -shrext > .so -o libtestengine.la libtestengine_la-libtestengine.lo - > lresolv > libtool: link: gcc -dynamiclib -Wl,-undefined -Wl,dynamic_lookup -o > .libs/libtestengine.0.so .libs/libtestengine_la-libtestengine.o -L > /usr/local/Cellar/openssl@1.1/1.1.1c/lib -lcrypto -lssl > -L/usr/local/Cellar/cmocka/1.1.5/lib -lcmocka -lresolv -g -O2 - > install_name /lib/libtestengine.0.so -compatibility_version 1 > -current_version 1.0 -Wl,-single_module > libtool: link: (cd ".libs" && rm -f "libtestengine.so" && ln -s > "libtestengine.0.so" "libtestengine.so") > libtool: link: ar cru .libs/libtestengine.a libtestengine_la- > libtestengine.o > libtool: link: ranlib .libs/libtestengine.a > libtool: link: ( cd ".libs" && rm -f "libtestengine.la" && ln -s > "../libtestengine.la" "libtestengine.la" ) > /Applications/Xcode.app/Contents/Developer/usr/bin/make check-TESTS > sed "s|ABSBUILDDIR|/Users/gert/openvpn-build- > mojave/tests/unit_tests/engine-key|" < > ../../../../openvpn.git/tests/unit_tests/engine-key/openssl.cnf.in > > openssl.cnf > PASS: check_engine_keys.sh > ============= > 1 test passed > ============= > > (I'm not sure where it is actually *calling* the > "check_engine_keys.sh", > but it says "test passed!" and I see ".so" up there)
Yes, it's using the standard test runner, so if it says PASS/FAIL: <script> it definitely called <script> > [..] > > Right, that's what the patch in the url does: uses .so on both mac > > and linux. > > I got all confused with your "v6" patch and your "v7" patch, which > did other things, and but did not have a "v6" in the history :-) > > *This* patch definitely looks like it's doing the right thing on > MacOS. Great, thanks ... I'll rewrap it and submit as a separate patch email with cover letter. James
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
