hi,
On 30/06/20 16:11, Gert Doering wrote:
Hi,
On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote:
@@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const
struct tuntap_options *o)
write_dhcp_u32_array(buf, 42, (uint32_t *)o->ntp, o->ntp_len, &error);
write_dhcp_u32_array(buf, 45, (uint32_t *)o->nbdd, o->nbdd_len, &error);
+ for (int i=0; i < o->domain_search_list_len; i++)
+ {
+ write_dhcp_search_str(buf, 119, o->domain_search_list[i], &error);
+ }
I assume that this won't work. In the DHCP answer, it must be a single
option with the concatenated list, not multiple answers with a single
domain name each.
gert
see https://tools.ietf.org/html/rfc3397
"
In the above diagram, Searchstring is a string specifying the
searchlist. If the length of the searchlist exceeds the maximum
permissible within a single option (255 octets), then multiple
options MAY be used, as described in "Encoding Long Options in the
Dynamic Host Configuration Protocol (DHCPv4)" [RFC3396
<https://tools.ietf.org/html/rfc3396>].
"
so you MAY use this option multiple times - and wireshark groks it fine. I
don't have a Windows 10
client to test it against, however, so I am hoping that someone (Selva?) can do
that for me.
cheers,
JJK
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
