Hi, I would suggest to keep this renaming but make it not fatal. A descriptive name is nice to have and we could even make the name configurable at some point in future.
Selva On Wed, Sep 2, 2020 at 8:40 AM Lev Stipakov <lstipa...@gmail.com> wrote: > From: Lev Stipakov <l...@openvpn.net> > > Renaming doesn't work on some machines ( > https://github.com/OpenVPN/openvpn-build/issues/187) > and we couldn't find the cause. Also others do not seem to do it, so let's > get rid of it. > > Signed-off-by: Lev Stipakov <l...@openvpn.net> > --- > src/openvpnmsica/openvpnmsica.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/src/openvpnmsica/openvpnmsica.c > b/src/openvpnmsica/openvpnmsica.c > index 31e90bd2..10d4a1cc 100644 > --- a/src/openvpnmsica/openvpnmsica.c > +++ b/src/openvpnmsica/openvpnmsica.c > @@ -1094,15 +1094,6 @@ ProcessDeferredAction(_In_ MSIHANDLE hInstall) > > GUID guidAdapter; > dwResult = tap_create_adapter(NULL, NULL, szHardwareId, > &bRebootRequired, &guidAdapter); > - if (dwResult == ERROR_SUCCESS) > - { > - /* Set adapter name. */ > - dwResult = tap_set_adapter_name(&guidAdapter, szName); > - if (dwResult != ERROR_SUCCESS) > - { > - tap_delete_adapter(NULL, &guidAdapter, > &bRebootRequired); > - } > - } > } > else if (wcsncmp(szArg[i], L"deleteN=", 8) == 0) > { > -- > 2.17.1 > > > > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel >
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
