[resent from proper address]

On 16/09/2020 15:48, Gert Doering wrote:
> Hi,
>
> On Tue, Sep 15, 2020 at 10:52:54PM +0200, David Sommerseth wrote:
>> ---
>> v2 - Process README files with correct instructions and details
>> v3 - Add missing -I$(top_srcdir)/include and explicitly state GNU Make
>>      requirement
>
> Unfortunately, we need a v4... stupid me...

Nah, we share the blame here ... I forgot about the builddir variant.  Which
is very well documented in the automake documentation.

> For in-tree builds, it is working:
>
> cc -c -o simple/simple.o -Wall -Wno-unused-parameter -Wno-unused-function -g
-O2 -std=c99 -I../.. -I../../include -fPIC simple/simple.c
> cc  -shared -fPIC -o simple/simple.so simple/simple.o
> rm simple/simple.o
>
> For out of tree builds, it is still failing:
>
> cc -c -o simple/simple.o -Wall -Wno-unused-parameter -Wno-unused-function -g
> -O2 -std=c99 -I../../../openvpn -I../../../openvpn/include -fPIC ../../..
> /openvpn/sample/sample-plugins/simple/simple.c
> ../../../openvpn/sample/sample-plugins/simple/simple.c:37:10: fatal error:
>       'openvpn-plugin.h' file not found
> #include "openvpn-plugin.h"
>          ^~~~~~~~~~~~~~~~~~
>
> because "openvpn-plugin.h" is not actually to be found in the source
> tree, but it's generated at compile time - so "-I../../include" will
> find it.
>
> The other -I should maybe also be "-I../.."?  What is it looking for
> in the $(top_builddir)?  The only .h file in $(top_builddir) is
> "config-msvc.h" - config.h is in "../.."
>

This is actually covered in the AM_CPPFLAGS docs here:
<https://www.gnu.org/software/automake/manual/html_node/Program-Variables.html>

I'll submit a v4 fixing this.


-- 
kind regards,

David Sommerseth
OpenVPN Inc



Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to