Good old "name vs index" thing.
According to "man" of netsh, index indeed could be used for "set
address" and "add route":
> interface - Interface name or index.
> + DWORD adapter_index;
> if (r6->adapter_index) /* vpn server special route */
> {
> - buf_printf(&out, "interface=%lu", r6->adapter_index );
> + adapter_index = r6->adapter_index;
> gateway_needed = true;
> }
> else
> {
> - buf_printf(&out, "interface=%lu", tt->adapter_index );
> + adapter_index = tt->adapter_index;
> }
Here I would do something like
DWORD adapter_index = tt->adapter_index;
if (r6->adapter_index)
{
adapter_index = r6->adapter_index;
gateway_needed = true;
}
to make code more concise, but I am fine with current implementation too.
Stared at the code, built and tested on MSVC/Win10. Works as expected.
Acked-by: Lev Stipakov <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
