> }
>
> void
> +make_empty_crl(struct tls_root_ctx *ctx)
> +{
> + if (ctx->crl == NULL)
> + {
> + ALLOC_OBJ_CLEAR(ctx->crl, mbedtls_x509_crl);
> + }
> + else
> + {
> + mbedtls_x509_crl_free(ctx->crl);
> + }
> +}
> +
This function is confsung me. This needs at least more documentation
what it is doing as docstring etc. I would also expect to have
mbedtls_x509_crl_init to init the struct and not just a malloc that set
the whole structure to zero. And mbedtls_x509_crl_free does from its
description doesn't guarantee that the object is left in a proper state.
Arne
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
