Hi,
Thanks for the review.
On Tue, May 25, 2021 at 4:06 AM Lev Stipakov <lstipa...@gmail.com> wrote:
>
> Hi,
>
> I got compilation error:
Oops.. I did not test building with _DEBUG defined.
>
> 2>openvpnmsica.c
> 2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(140,1):
> warning C4002: too many arguments for function-like macro invocation
> 'TEXT'
> 2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(140,24):
> error C2143: syntax error: missing ')' before ';'
> 2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(132,9):
> warning C4473: 'swprintf_s' : not enough arguments passed for format
> string
> 2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(132,9):
> message : placeholders and their parameters expect 3 variadic
> arguments, but 0 were provided
> 2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(132,9):
> message : the missing variadic argument 1 is required by format string
> '%ls'
>
> OTOH it is easily fixed by this change:
>
> diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c
> index a4008d8f..1fb35f86 100644
> --- a/src/openvpnmsica/openvpnmsica.c
> +++ b/src/openvpnmsica/openvpnmsica.c
> @@ -129,7 +129,7 @@ _debug_popup(_In_z_ LPCTSTR szFunctionName)
> /* Compose the pop-up message. */
> _stprintf_s(
> szMessage, _countof(szMessage),
> - TEXT("The %") TEXT(PRIsLPTSTR) TEXT(" process (PID: %u) has
> started to execute the %"
> + TEXT("The %") TEXT(PRIsLPTSTR) TEXT(" process (PID: %u) has
> started to execute the %")
> TEXT(PRIsLPTSTR) TEXT(" custom action.\r\n")
> TEXT("\r\n")
> TEXT("If you would like to debug the custom action, attach a
> debugger to this process and set breakpoints before dismissing this
> dialog.\r\n")
Will submit a v2 with this one and the space below.
Selva
>
> A nit-pick:
>
> > - _stprintf_s(szTitle, _countof(szTitle), TEXT("%s v%s"),
> > szFunctionName, TEXT(PACKAGE_VERSION));
> > + _stprintf_s(szTitle, _countof(szTitle), TEXT("%") TEXT(PRIsLPTSTR)
> > TEXT("v%") TEXT(PRIsLPTSTR),
> > + szFunctionName, TEXT(PACKAGE_VERSION));
>
> Otherwise looks good - compiled with MSVC and slightly tested. If Gert
> can fix abovementioned thigs (add a parenthesis and a whitespace)
> consider it as an ack.
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
