Hi,
On 05/04/2022 12:00, Frank Lichtenheld wrote:
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
Seems trivial.
Antonio Quartulli <a...@unstable.cc> hat am 02.04.2022 09:09 geschrieben:
[...]
+ if (tt->hand != NULL)
+ {
+ dmsg(D_WIN32_IO_LOW, "Attempting CloseHandle on %s adapter",
adaptertype);
+ if (!CloseHandle(tt->hand))
+ {
+ msg(M_WARN | M_ERRNO, "Warning: CloseHandle failed on %s adapter",
adaptertype);
+ }
+ tt->hand = NULL;
Setting hand to NULL is a slight behavior change, it wasn't there before.
It might be nice to acknowledge it in the commit message just to confirm that
it was a deliberate change.
Yes, it was a deliberate change.
This helper function will be invoked by (possibly) multiple places, so
it's better to set a precondition and prevent a double close.
I agree we should add a sentence to the commit message about this.
Regards,
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
