Hi,
On Sat, Apr 02, 2022 at 09:08:58AM +0200, Antonio Quartulli wrote:
> +int
> +net_iface_del(openvpn_net_ctx_t *ctx, const char *iface)
> +{
> + struct argv argv = argv_new();
> +
> + argv_printf(&argv, "%s link del %s", iproute_path, iface);
> + openvpn_execve_check(&argv, ctx->es, S_FATAL, "Linux ip link del
> failed");
> +
> + argv_free(&argv);
On "failure to remove something" we generally do not hard-abort right
away but just report the error, and continue with cleaning up things.
So maybe net_iface_del() should do the same thing?
(See "undo_ifconfig_ipv4()", for example, or most other close_tun() related
openvpn_execve_check() calls)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
