> Arne Schwabe <[email protected]> hat am 22.04.2022 16:29 geschrieben: > > > This changes this macro to a better named inline function. This > introduces a slight whitespace problem but the next refactoring will > move the incorrectly intended block to its own function anyway.
Could it be that you forgot to update the commit message when you squashed this commit? Looking at the diff this already moves the block to its own function? Apart from that and a small whitespace oddity noted below the changes look good (in the sense that they shouldn't change behavior and just move code around). > --- > src/openvpn/ssl.c | 100 ++++++++++++++++++++++++++-------------------- > 1 file changed, 57 insertions(+), 43 deletions(-) > > diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c > index bad59f2a1..4ca093243 100644 > --- a/src/openvpn/ssl.c > +++ b/src/openvpn/ssl.c [...] > @@ -2428,6 +2430,54 @@ session_move_pre_start(const struct tls_session > *session, > return true; > > } > + > +/** > + * Moves the key to state to S_ACTIVE and also advances the multi_state state > + * machine if this is the initial connection. Spurious whitespace at the end of the line Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
