diff --git a/doc/man-sections/script-options.rst

This is more related to 4/4 and should go there for code archaeology reasons.

+    /* the server can suggest a backoff time to the client, it
+     * will still be capped by the max timeout between connections
+     * (300s by default) */
+    int server_backoff_time;

This should be (parsed as) an unsigned value. Negative backup requires too
advanced physics. ;-)

*All* other connect related settings (connect_retry_seconds, connect_retry_seconds_max, connect_timeout, ...) are int. Making this
single one unsigned int means mixing integer types and having to cast
one parameter of max_int(a, b), so I would rather be consistent in having all the same type.



+++ b/src/openvpn/options_util.h
\ No newline at end of file

Again

uncrustify does not complain about that. Will add manually


diff --git a/src/openvpn/push.c b/src/openvpn/push.c
index 1c4e637e4..3b3dce642 100644
--- a/src/openvpn/push.c
+++ b/src/openvpn/push.c
@@ -51,7 +52,6 @@ void
  receive_auth_failed(struct context *c, const struct buffer *buffer)
  {
      msg(M_VERB0, "AUTH: Received control message: %s", BSTR(buffer));
-    c->options.no_advance = true;

      if (!c->options.pull)
      {

I think we want to keep this as the default. If I read the code correctly, at
the moment the default behavior is "advance addr" if none is given, which feel
wrong to me, given what I have read about the feature.


That looks like a mistake

Arne



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to