Stared-at-code.
Fixed file name reference in the documentation (as agreed), and TAB
in Makefile.am.
Tested with the "regular" server and client setups - nothing breaks,
but the new functionality isn't excercised, so this is not surprising.
Unit tests pass, too, which is good :-) - there is no real test for
"advance addr" vs. "advance remote" (there is "advance remote", but the
flags are not tested). Maybe these could be added?
To actually *test* (and continuiously verify) the functionality I needed to
trick around a bit, creating a server-side script that "remembers" the
last TEMP fail, and succeeds on the 4th try... but with that, it does
what it says on the tin - advance (to next addr) or not, stick to the
specified backoff time (remember to configure "--connect-retry 1" to *see*
the effect of short backoff timers :-) )
Your patch has been applied to the master branch.
commit c9474fa316a6f73286ed97b36c8f8b1ba62141bd
Author: Arne Schwabe
Date: Wed Sep 14 19:01:34 2022 +0200
Implement AUTH_FAIL, TEMP message support
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Heiko Hund <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg25210.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
