Acked-by: Gert Doering <g...@greenie.muc.de> This doesn't change anything code wise (where it changes the if/else, it just gets rid of the second-to-last empty block, and by adding an early exit gets rid of an indentation level), but improves clarity, so very welcome. The diffs to bio_read() work better with "git show -w".
Client-side tested that things still work :-) Your patch has been applied to the master and release/2.6 branch. commit f2454ec6363d5578875d020179b38074b3c10964 (master) commit da747c3664d9330a1e38369aadddefb6ba5e8416 (release/2.6) Author: Arne Schwabe Date: Thu Dec 15 20:01:40 2022 +0100 Eliminate or comment empty blocks and switch fallthrough Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20221215190143.2107896-6-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25735.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel