Hi, Stared at the code and slightly tested - works as expected. Nice that we display interface id:
add_route_ipv6(2000::/3 -> 2001:db8:0:456::1 metric 200) IF 74 instead of device name: add_route_ipv6(2000::/3 -> 2001:db8:0:456::1 metric 200) dev OpenVPN Data Channel Offload Another thing which would be good to improve is a consistency between IPv4 and IPv6 log messages: 2023-01-20 11:59:56 us=265000 C:\Windows\system32\route.exe ADD 128.0.0.0 MASK 128.0.0.0 10.58.0.1 2023-01-20 11:59:56 us=281000 ROUTE: CreateIpForwardEntry succeeded with dwForwardMetric1=25 and dwForwardType=4 2023-01-20 11:59:56 us=281000 Route addition via ipapi [adaptive] succeeded 2023-01-20 11:59:56 us=281000 add_route_ipv6(2000::/3 -> 2001:db8:0:456::1 metric 200) IF 74 2023-01-20 11:59:56 us=281000 IPv6 route added using ipapi - for IPv4 we print route.exe command line (for debugging I think?, since we use IPAPI), and we don't do it for IPv6. - for IPv4 we print "Route addition via ipapi [adaptive] succeeded", for IPv6 "IPv6 route added using ipapi" Besides that, we use capitalized IPAPI spelling in delete_route. That function could probably benefit from the same refactoring as add_route. Anyway, this is not really about this patch. Acked-by: Lev Stipakov <lstipa...@gmail.com> _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
