Hi, On Wed, Feb 1, 2023 at 6:56 AM Frank Lichtenheld <fr...@lichtenheld.com> wrote:
> On Sat, Jan 28, 2023 at 05:34:21PM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair <selva.n...@gmail.com> > > > > Signed-off-by: Selva Nair <selva.n...@gmail.com> > > --- > > src/openvpn/cryptoapi.c | 44 +++++++++++------------------------------ > > 1 file changed, 12 insertions(+), 32 deletions(-) > > > > diff --git a/src/openvpn/cryptoapi.c b/src/openvpn/cryptoapi.c > > index 6ff4fcb5..9fd5aea9 100644 > > --- a/src/openvpn/cryptoapi.c > > +++ b/src/openvpn/cryptoapi.c > > @@ -210,49 +210,29 @@ find_certificate_in_store(const char *cert_prop, > HCERTSTORE cert_store) > > This seems to ask for a unittest. Would be nice indeed. But, I've never tried to enable cmocka in our Windows build -- does it work? If it does, I would be inclined to add tests for this as well as some other functions in cryptoapi.c Regards, Selva
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
