CC: list ---------- Forwarded message --------- From: Selva Nair <selva.n...@gmail.com> Date: Wed, Feb 8, 2023 at 11:34 PM Subject: Re: [Openvpn-devel] [PATCH 4/5] Add missing stdint.h includes in unit tests files To: Arne Schwabe <a...@rfc2549.org>
Hi, On Tue, Feb 7, 2023 at 7:19 PM Arne Schwabe <a...@rfc2549.org> wrote: > My mingw compiler/headers (mingw-w64 10.0.0 on macOS) seem to be more > pendantic than the one that comes with Ubuntu 22.04 (github actions) or > any of the other platforms including msvc/normal windows header. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org> > --- > tests/unit_tests/example_test/test.c | 1 + > tests/unit_tests/example_test/test2.c | 1 + > tests/unit_tests/openvpn/mock_msg.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/tests/unit_tests/example_test/test.c > b/tests/unit_tests/example_test/test.c > index ea31b884d..c174025cc 100644 > --- a/tests/unit_tests/example_test/test.c > +++ b/tests/unit_tests/example_test/test.c > @@ -4,6 +4,7 @@ > #include <stdarg.h> > #include <string.h> > #include <setjmp.h> > +#include <stdint.h> > #include <cmocka.h> > > static int > diff --git a/tests/unit_tests/example_test/test2.c > b/tests/unit_tests/example_test/test2.c > index 5a186d5d7..bb54633c8 100644 > --- a/tests/unit_tests/example_test/test2.c > +++ b/tests/unit_tests/example_test/test2.c > @@ -4,6 +4,7 @@ > #include <stdarg.h> > #include <string.h> > #include <setjmp.h> > +#include <stdint.h> > #include <cmocka.h> > > > diff --git a/tests/unit_tests/openvpn/mock_msg.c > b/tests/unit_tests/openvpn/mock_msg.c > index 3ede98c00..3fa9a166f 100644 > --- a/tests/unit_tests/openvpn/mock_msg.c > +++ b/tests/unit_tests/openvpn/mock_msg.c > @@ -32,6 +32,7 @@ > #include <stdio.h> > #include <stdlib.h> > #include <setjmp.h> > +#include <stdint.h> > #include <cmocka.h> Actually it may not be your setup: mingw on Linux also requires this if using cmocka-master branch. cmocka-1.1.5 works without this include for me. That would explain why we haven't seen this error yet in native builds. Anyway, cmocka docs also tell us to always include <stdint.h>. Acked-by: Selva Nair <selva.n...@gmail.com>
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
