Acked-by: Gert Doering <g...@greenie.muc.de> Well spotted. Whatever we decide to do with 2/2, this is the correct way to deal with getpw*() returns.
I have not tested every possible combination of options, but I have stared-at-code (looks good), had the buildbots test it, and ran a "--user nobody" DCO instance on Linux (works). Your patch has been applied to the master and release/2.6 branch. commit 62024046dffd6ff10309b791cd6600fe80bc46e3 (master) commit 85ad9d2520d571dff93d2b15002f151c10000804 (release/2.6) Author: Selva Nair Date: Mon Mar 6 00:33:45 2023 -0500 Do not save pointer to 'struct passwd' returned by getpwnam etc. Signed-off-by: Selva Nair <selva.n...@gmail.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20230306053346.796992-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26332.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel