Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email )
Change subject: dco: don't use NetLink to exchange control packets ...................................................................... Patch Set 4: (5 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/28/comment/edcaa03e_7d307609 PS4, Line 1702: */ > Maybe move that comment (the part that still applies) to the new > socket_is_dco_win method? hmm I'd add a different working because it is not about where to send control packets, but just checking if DCO is enabled on a link or not. but yeah, we could definitely add some doc to socket_is_dco_win File src/openvpn/ovpn_dco_linux.h: http://gerrit.openvpn.net/c/openvpn/+/28/comment/be25a0d8_f403b236 PS4, Line 30: OVPN_CMD_NEW_PEER, > Didn't you want to add a length field for the residual TCP buffer and just 0 > here to avoid another A […] nah, adding a field does not break the API. We can add it later as it fixes a separate issue. File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/28/comment/fdce9d57_fe86f5e0 PS4, Line 1184: /* unified UDPv4 and UDPv6 and DCO (kernel adds size header) */ > But here we remove the comment, even though it is also true here. again, why do we talk about size header if this is UDP? http://gerrit.openvpn.net/c/openvpn/+/28/comment/af827c3f_5e4fc158 PS4, Line 209: #define SF_DCO_WIN (1<<5) > Is using a flag really better than a bool here? this is Lev's doing :-D Technically we already have the socketflags bitfield, so re-using it is not a bad idea and it is less invasive compared to adding a member that is used by one platform only. http://gerrit.openvpn.net/c/openvpn/+/28/comment/c793d3d9_3d0bef67 PS4, Line 1069: * will strip the length header */ > here the comment is kept (since it is still true) I am confused. this is UDP, how come we talk about length header? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/28?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia1297c3ae9a28b188ed21ad21ae96fff3d02ee4d Gerrit-Change-Number: 28 Gerrit-PatchSet: 4 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 Gerrit-Comment-Date: Thu, 09 Mar 2023 14:21:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
