Acked-by: Gert Doering <g...@greenie.muc.de>
This is a welcome addition so we can have actual cryptoapi unit
tests. The code looks reasonable, and GHA says "it passes"...
Run ./unittests/cryptoapi_testdriver.exe
[==========] Running 2 test(s).
[ RUN ] test_parse_hexstring
[ OK ] test_parse_hexstring
[ RUN ] import_certs
[ PASSED ] 2 test(s).
[ OK ] import_certs
[==========] 2 test(s) run.
I have tried testing this on a "real" Win10 VM, but I am missing some
intricacies with the cert store - I wanted to see if certs are properly
cleaned up, but I can't even see my own .p12 I have imported, so I am
doing something wrong...
Your patch has been applied to the master and release/2.6 branch.
commit d6cf0239e835d98b66c71d701e70128db9ca7e9a (master)
commit e6011868c40aaf91d30d084b1b454f7709c855fd (release/2.6)
Author: Selva Nair
Date: Tue Mar 14 21:35:13 2023 -0400
Import some sample certificates into Windows store for testing
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20230315013516.1256700-2-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26417.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
