Acked-by: Gert Doering <[email protected]>
Thanks, this change makes sense. I have not actively tried to provoke
it (like, by connecting to a "fake SOCKS server" that will trigger it),
but the change is obviously an improvement to "if it's not ==1, it
must be a TCP error!").
I do test the SOCKS code in my t_client runs, but all my SOCKS servers
are well-behaved (and the regular t_client cannot handle "expect failure"
cases anyway). Room for improvement.
So, I've tested this on a regular client using a well-behaved SOCKS
proxy, and as expected, "it does not break anything" :-)
Your patch has been applied to the master and release/2.6 branch.
commit 172640189277c940439d24fd31a59b8faffd0b3e (master)
commit c20a15844829a186b4d5256b0e8d76b8eb074845 (release/2.6)
Author: Selva Nair
Date: Sat Mar 18 10:13:30 2023 -0400
Improve error message on short read from socks proxy
Signed-off-by: Selva Nair <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg26437.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
