I've submitted this to "basic client/server testing" plus "GHA build", just to be sure that nothing breaks - but this doesn't excercise the new code at all.
Stare-at-code says "it should do what it says on the lid", and the code is actually a bit simpler this way, not having to maintain separate addr4/addr6_defined variables etc. Some basic tests (running openvpn from the cli with --dns option and looking at "show_dns_options()" output) look good. Didn't look at the environment variables or Windows DHCP. The error message for "--dns server 3 address" (with no addresses) is a bit confusing now Options error: --dns: unknown option type 'server' or missing or unknown parameter but it does not crash or otherwise misbehave. Exceeding the number of allowed addresses leads to Options error: --dns server 3: malformed address or maximum exceeded '9.9.9.9' (good). Your patch has been applied to the master and release/2.6 branch. commit 424ae5906388af8769ae448080fa3b7ec266e8d8 (master) commit 3b967e7e05f679203ce26e027fcea5f7b4709eaa (release/2.6) Author: Heiko Hund Date: Fri Mar 10 06:08:12 2023 +0100 dns option: allow up to eight addresses per server Signed-off-by: Heiko Hund <he...@ist.eigentlich.net> Acked-by: Arne Schwabe <a...@rfc2549.org> Message-Id: <20230310050814.67246-1-he...@ist.eigentlich.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26386.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel