As this patch has a bit of mixed history "who wrote it, who ACKed it, what happened afterwards" I decided to record the ACK from Arne and Kristof.
v4 has been tested on FreeBSD with DCO enabled, p2mp udp server, one client being connected all the time and the other client reconnecting (moving between peer-id 1 and 2), packets going back and forth, looking at the resulting counters. Everything looked as expected. (This is basically an optimization that was discussed in November already but nobody followed up on it - and with the upcoming Linux DCO counter patches, the topic "why use iterator when you have an array?" resurfaced - thanks, Antonio, for covering FreeBSD too) Your patch has been applied to the master and release/2.6 branch. commit 03145f223236df90b35d1db444319fd3f785792b (master) commit 5acefd944c6a8a4338b5105ffe6b9ffce6bad330 (release/2.6) Author: Antonio Quartulli Date: Thu Mar 23 09:03:41 2023 +0100 dco-freebsd: use m->instances[] instead of m->hash Signed-off-by: Antonio Quartulli <a...@unstable.cc> Acked-by: Arne Schwabe <a...@rfc2549.org> Acked-by: Kristof Provost <k...@freebsd.org> Message-Id: <20230323080341.51624-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/search?l=mid&q=20230323080341.51624-1-g...@greenie.muc.de Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel