Acked-by: Gert Doering <g...@greenie.muc.de>
I have listened to the discussion, and I think we all agree that we
need to revisit this "DCO counter" business:
- definition of c2 structure elements
- do we need extra fields for "dco counters"?
- do we need more counters? Windows currently has
"TransportBytes*" and "TunBytes*", while FreeBSD only has "bytes"
(which are what, exactly?)
-> *I* definitely need a better understanding of these
- when and where do we query the kernel for counters (timer, signal, ...?)
This said, we want the functionality now :-) - so, I have tested this
(on FreeBSD), and it does what it says, and the code looks reasonable
according to "it will not access undefined pointers, will not leak
memory" etc.
Your patch has been applied to the master and release/2.6 branch.
commit d5238627e4fab93a6c09816c60eb90e237b626c3 (master)
commit d598871ca9fb7b4814ee8d8edfb26d20479bb6ed (release/2.6)
Author: Lev Stipakov
Date: Wed Mar 22 13:32:49 2023 +0200
Print DCO client stats on SIGUSR2
Signed-off-by: Lev Stipakov <l...@openvpn.net>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20230322113249.2039-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26471.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
