Sorry for taking so long on this - it hit post-release fatigue...
I did test this by running t_client test (which use signals to kill
running openvpn) across all supported OSes, and server side tests on
Linux, with and without DCO. Of course this is not really excercising
the signal handling code, but at least it confirms that nothing is
grossly broken.
Stared at the code & the manpages as well. Following my path through
the twisty maze of passages (especially halt_low_priority_signals())
was not easy, but "it seems to make sense" (this blocks signals, but
there is no new code to unblock - if I'm reading this right, this is
because we are at "exit (single) instance" time, and unblocking signals
will be done at init_instance_handle_signals() on the reconnection).
The actual "change to POSIX ways" part of this is fairly trivial
and easy to understand :-) - though I do wonder why you're using
an extra variable for block_mask -> sa.sa_mask, and not using
sigfillset(&sa.sa_mask) - at least on BSD on Linux, both are sigset_t,
so it should do the same thing in a slightly more direct way.
Your patch has been applied to the master branch.
commit 3abfc0fb5ea522fb5fc45fddbf35c3cc5c8e9ef1
Author: Selva Nair
Date: Sat Jan 28 16:59:00 2023 -0500
Improve signal handling using POSIX sigaction
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
Message-Id: <20230128215901.2207208-1-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26087.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
