Am 27.07.23 um 10:52 schrieb Merten Fermont:
Fixes error that --pull is an unknown option in client config.
---
openvpn/client/cliopt.hpp | 1 +
1 file changed, 1 insertion(+)

diff --git a/openvpn/client/cliopt.hpp b/openvpn/client/cliopt.hpp
index f7be44a8..431791f3 100644
--- a/openvpn/client/cliopt.hpp
+++ b/openvpn/client/cliopt.hpp
@@ -797,6 +797,7 @@ class ClientOptions : public RC<thread_unsafe_refcount>
         "mute-replay-warnings",
         "nobind", /* only behaviour in v3 client anyway */
         "prng",
+        "pull", /* option is implied by 'client' */
         "rcvbuf",         /* present in many configs */
         "replay-persist", /* Makes little sense in TLS mode */
         "script-security",


While that will work, it would be better to not ignore that option but handle it in a similar way to --client. In general we should actually throw an error if neither client or tls-client+pull are present as OpenVPN3 cannot operate without these in p2p mode.

Arne



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to