Acked-by: Gert Doering <g...@greenie.muc.de> Yep, Coverity is right :-) - silly code. Fix is in the same style we use elsewhere, so fine.
(The whole error handling on route addition is a bit wonky, but even then we should not forget about errors) Test compiled on Linux, just to be sure I did not overlook anything. Your patch has been applied to the master and release/2.6 branch. commit 8067cc8d1b384d3eb0fc9000992710b02951b266 (master) commit 09e2360a163077001fd33f2f338cf337b45b9ab6 (release/2.6) Author: Frank Lichtenheld Date: Fri Jul 28 14:47:12 2023 +0200 route: Fix overriding return value of add_route3 Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <60951251cdb2f39b20cfc86130c2dc0570ba0363-h...@gerrit.openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26900.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel