Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/426?usp=email )
Change subject: Do not check key_state buffers that are in S_UNDEF state ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/426/comment/096ce4c5_5a724a5c : PS1, Line 3192: if (ks->state == S_UNDEF) the crashdump / backtraces I received today confirm that this is the root cause, ks->state == S_UNDEF and thus, ks->send_reliable == NULL. I'd feel a bit more comfortable to check "if (ks->send_reliable)" here, though - so we're not ending in a crash here again should another state be introduced in 2.8 where ks->state is something like "S_CLEARED" and bäm, NULL pointer access again. (We can check both, and complain if ks->send_reliable is NULL if ks->state is *not* S_UNDEF) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/426?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I226a73d47a2b1b29f7ec175ce23a806593abc2ac Gerrit-Change-Number: 426 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 15 Nov 2023 10:29:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
