The patch looks reasonable so far. Haven't tested it, just test compiled with GHA.
Looking forward to the day we can get rid of --ip-win32, and simplify all these messages having '"%s ...", prefix' in them. I have taken the liberty of wrapping the open_tun() line - "80-110 chars" is our limit, not "155". Your patch has been applied to the master branch. commit 85fc834b0229b87e466b4f60bd2618b2ecd27a5f (master) commit 6127858f302785fa81cb9b943a71af972531070c (release/2.6) Author: Lev Stipakov Date: Wed Nov 15 13:06:56 2023 +0100 Warn if pushed options require DHCP Signed-off-by: Lev Stipakov <l...@openvpn.net> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Message-Id: <20231115120656.6825-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27403.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel