Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/467?usp=email
to review the following change.
Change subject: unit_tests: remove includes for mock_msg.h
......................................................................
unit_tests: remove includes for mock_msg.h
Not actually used.
Change-Id: I5e394bb73702d87562ed354100eaff9b41f5389e
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M tests/unit_tests/openvpn/test_auth_token.c
M tests/unit_tests/openvpn/test_crypto.c
M tests/unit_tests/openvpn/test_packet_id.c
M tests/unit_tests/openvpn/test_pkt.c
M tests/unit_tests/openvpn/test_tls_crypt.c
5 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/67/467/1
diff --git a/tests/unit_tests/openvpn/test_auth_token.c
b/tests/unit_tests/openvpn/test_auth_token.c
index d96984f..a027330 100644
--- a/tests/unit_tests/openvpn/test_auth_token.c
+++ b/tests/unit_tests/openvpn/test_auth_token.c
@@ -36,8 +36,6 @@
#include "auth_token.c"
-#include "mock_msg.h"
-
struct test_context {
struct tls_multi multi;
struct key_type kt;
diff --git a/tests/unit_tests/openvpn/test_crypto.c
b/tests/unit_tests/openvpn/test_crypto.c
index 5564524..9e5469a 100644
--- a/tests/unit_tests/openvpn/test_crypto.c
+++ b/tests/unit_tests/openvpn/test_crypto.c
@@ -38,7 +38,6 @@
#include "options.h"
#include "ssl_backend.h"
-#include "mock_msg.h"
#include "mss.h"
static const char testtext[] = "Dummy text to test PEM encoding";
diff --git a/tests/unit_tests/openvpn/test_packet_id.c
b/tests/unit_tests/openvpn/test_packet_id.c
index 90c67ac..2a2a973 100644
--- a/tests/unit_tests/openvpn/test_packet_id.c
+++ b/tests/unit_tests/openvpn/test_packet_id.c
@@ -36,8 +36,6 @@
#include "packet_id.h"
#include "reliable.h"
-#include "mock_msg.h"
-
struct test_packet_id_write_data {
struct {
uint32_t buf_id;
diff --git a/tests/unit_tests/openvpn/test_pkt.c
b/tests/unit_tests/openvpn/test_pkt.c
index 9f49ee7..7f05184 100644
--- a/tests/unit_tests/openvpn/test_pkt.c
+++ b/tests/unit_tests/openvpn/test_pkt.c
@@ -40,7 +40,6 @@
#include "ssl_pkt.h"
#include "tls_crypt.h"
-#include "mock_msg.h"
#include "mss.h"
#include "reliable.h"
diff --git a/tests/unit_tests/openvpn/test_tls_crypt.c
b/tests/unit_tests/openvpn/test_tls_crypt.c
index ed7c794..465543a 100644
--- a/tests/unit_tests/openvpn/test_tls_crypt.c
+++ b/tests/unit_tests/openvpn/test_tls_crypt.c
@@ -36,8 +36,6 @@
#include "tls_crypt.c"
-#include "mock_msg.h"
-
/* Define this function here as dummy since including the ssl_*.c files
* leads to having to include even more unrelated code */
bool
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/467?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5e394bb73702d87562ed354100eaff9b41f5389e
Gerrit-Change-Number: 467
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
