Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export ...................................................................... Patch Set 5: Code-Review-2 (3 comments) Patchset: PS5: feature-ack, but the code is not fully there yet File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/a893a87b_2e6a6e2a : PS5, Line 1841: return false; there is whitespace missing at the first and second line wrap ("thisserver" and "(RFC 5705)support" File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/34f227b9_5a68d2c6 : PS5, Line 3661: } I might need new glasses, but as far as I can see, this code does all the checks, and *claims* to enable the option - but the only place I can see where the option is actually turned on is "if it's passed on the command line"...? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70 Gerrit-Change-Number: 460 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 12 Dec 2023 07:33:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
