Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email )
Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set ...................................................................... Patch Set 1: (1 comment) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/482/comment/d7d9f828_cf70f1a1 : PS1, Line 19: However, due to bug we always attempted to remove DNS/WINS, > What's the issue with always trying to remove these? Is there an error > message in the log or somethi […] Why delete something that we haven't added? We have this logic (do not delete if not added) for DNS6 already. Besides, in some cases it might take up to 3 seconds. 2023-12-14 07:45:35 Closing DCO interface 2023-12-14 07:45:35 delete_route_ipv6(fd00:abcd:194:1::/64) 2023-12-14 07:45:35 IPv6 route deletion via service succeeded 2023-12-14 07:45:35 INET6 address service: remove fd00:abcd:194:1::1005/128 2023-12-14 07:45:38 WINS servers deleted using service -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/482?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I21a36d24f8e213c780f55acbe3e4df555c93542a Gerrit-Change-Number: 482 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: d12fk <he...@openvpn.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Mon, 18 Dec 2023 07:53:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: d12fk <he...@openvpn.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel