For whatever reason, doxygen documentation hunks for get_user_pass_cr() sneaked into this patch - I have skipped those, as it's not related to this patch and should go into the user_pass related patches (UT etc) (maybe just a git rebase artefact anyway).
With the early return / ASSERT() it's a bit harder to see that the code is "really just moved, unchanged, to avoid a forward call" - and "git diff -w" doesn't help here either. Verified by staring at the diff. Your patch has been applied to the master branch. commit 30751632b5d919d6a01a625be48060ee23b4f968 Author: Frank Lichtenheld Date: Sat Dec 30 15:32:48 2023 +0100 misc: make get_auth_challenge static Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20231230143248.1625-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27864.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel