Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/492?usp=email )

Change subject: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo 
by zero"
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
But this does not really change anything. It just flips the if around. Is this 
fooling Coverity?

And the assumption is that somehow cipher_kt_block_size could return 0 which is 
not something that happens for a valid cipher.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/492?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iaef904ee2448dc0b9ad396d3ad9ae21b9dd6281e
Gerrit-Change-Number: 492
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Tue, 09 Jan 2024 11:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to