Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/495?usp=email )
Change subject: CMakeLists.txt: Don't fail on missing compile_commands.json ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/495/comment/ff72c046_d852df10 : PS2, Line 7: CMakeLists.txt: Don't fail on missing compile_commands.json Change to CMake: Don't fail if compile_commands.json symlink can't be created. http://gerrit.openvpn.net/c/openvpn/+/495/comment/78f9bf15_9a748563 : PS2, Line 15: There a two issues: I would suggest replacing this whole section with: <---> Creating symlinks on Windows by default requires an elevated prompt, which is not normally the case (but it turned out is the case for GHA). Without elevated prompt this fails the build. Fix by make symlink creation non-fatal by providing variable to store result. Since CMAKE_EXPORT_COMPILE_COMMANDS works only on Ninja and Makefile generators and doesn't produce anything on MSVC, the symlink is useless in this case anyway. <----> This makes it clearer what the actual issue is, but mentions the other issue as justification. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/495?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic19f859c3aca8b30aa51b12dcb906a6e7e735019 Gerrit-Change-Number: 495 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 14:13:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
