Attention is currently required from: cron2, d12fk, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email )
Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Patchset: PS5: Generally looks fine to me File src/openvpn/win32.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/4f22baef_1cbaf8d1 : PS1, Line 1225: if (ret == false) > Yes, but no. The function has a single point of return, let's keep it that > way. […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 5 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 16:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: d12fk <he...@openvpn.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
