Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/505?usp=email )

Change subject: Add unit test for encrypting/decrypting data channel
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/505/comment/cdd6570d_b4598d99 :
PS3, Line 13: Change-Id: Ifa5ae96165d17b3cae4afc53e844bb34d1610e58
Missing sign-off


File tests/unit_tests/openvpn/test_ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/505/comment/197b238b_17f15314 :
PS3, Line 133:         size_t impl_iv_len = cipher_ctx_iv_length(cipher) - 
sizeof(packet_id_type);
can make this "const"



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/505?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifa5ae96165d17b3cae4afc53e844bb34d1610e58
Gerrit-Change-Number: 505
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Comment-Date: Mon, 05 Feb 2024 12:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to