Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email )
Change subject: Http-proxy: Fix bug preventing proxy credentials caching. ...................................................................... Patch Set 1: Code-Review-2 (5 comments) Patchset: PS1: Definitely has issues File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/a2ced5bd_47c89245 : PS1, Line 1861: SHOW_BOOL(ce.http_proxy_options->nocache); This belongs into show_connection_entry like the other o->ce options File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/99f3b845_b241aa5b : PS1, Line 275: if (!static_proxy_user_pass.defined || (is_first_time && !p->options.nocache) ) This condition feels wrong to me. As I understand the code this should never be true when p->options.nocache is true. Or do I understand the code wrong? http://gerrit.openvpn.net/c/openvpn/+/523/comment/67ae3287_17906ea3 : PS1, Line 278: p->options.auth_file, I think you messed up a rebase on top of a634cc5eccd55f1d14197da7376bb819bdf72cb6 here. Your code ignores auth_file_up again. http://gerrit.openvpn.net/c/openvpn/+/523/comment/3303fbc3_b1eee104 : PS1, Line 546: get_user_pass_http(p); So previously this forced a reset of the credentials. This you removed. Are you sure this is correct? If yes, why? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Fri, 16 Feb 2024 16:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
