Hi, On Mon, Feb 19, 2024 at 02:08:56PM +0100, Antonio Quartulli wrote: > This said, I do believe this patch fixes these issues in one go as the new > PIP_OPT_MASK will match all the flags mentioned above.
Yes, but then we do not need that if() anymore at all - if we go in
there, no matter if we have anything to do (like, we have v6 bits set,
and enter the v4 branch).
Maybe that would be a more reasonable approach here... get rid of the
umbrella if(), and check individual bits inside. It seems to be a
micro-optimization "skip this branch if we have no single feature active",
while at least MSSFIX is active by default.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
