Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/529?usp=email )
Change subject: Persist-key: enable persist-key option by default ...................................................................... Patch Set 1: Code-Review-1 (6 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/529/comment/99bc33fe_177eba51 : PS1, Line 9: This commit changes the default behavior of the OpenVPN Nitpick: just use "Change the default behavior". "This commit" is redundant and clunky. Patchset: PS1: Functionally looks good to me. Some documentation improvements suggested. File doc/man-sections/signals.rst: http://gerrit.openvpn.net/c/openvpn/+/529/comment/4c986d46_e82cde2f : PS1, Line 13: remote IP address/port based on ``--persist-tun``, ``--persist-local-ip`` Trailing whitespace File doc/man-sections/unsupported-options.rst: http://gerrit.openvpn.net/c/openvpn/+/529/comment/8164c8c9_a1ae98fb : PS1, Line 47: Removed in OpenVPN 2.7. Corresponding behavior is now always enabled. "Corresponding behavior" is very vague. Let's write "Keys are now always persisted across restarts" or something like that. File sample/sample-config-files/server.conf: http://gerrit.openvpn.net/c/openvpn/+/529/comment/910d57b4_d0613104 : PS1, Line 277: # The persist options will try to avoid Nitpick: "The persist options" not correct anymore, since it is only one option now 😊 File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/529/comment/a6f6455c_7e115ef1 : PS1, Line 6963: "The corresponding behavior is now always enabled." Same comment about "corresponding behavior" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/529?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I57f1c2ed42bd9dfd43577238749a9b7f4c1419ff Gerrit-Change-Number: 529 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 13:42:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
