Verified ("git show -w") that this is indeed just removing one level of indentation + ICMP spelling fixes (good catch).
Given the sequence of checks, this ordering is indeed a bit more costly for the "no PIP bits are set" (as is_ipv4() has to do more checking than "are we interested in this at all?") - but since we basically always default to having MSSFIX active, this is a bit moot. For good measure, subjected to GHA and server side test run. Your patch has been applied to the master branch. commit 6456d861f3f1006ccee0a7f94a159f4afe1d3178 Author: Gianmarco De Gregori Date: Thu Mar 7 13:46:16 2024 +0100 Minor fix to process_ip_header Signed-off-by: Gianmarco De Gregori <gianma...@mandelbit.com> Acked-by: Arne Schwabe <arne-open...@rfc2549.org> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Message-Id: <20240307124616.16358-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28345.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel