Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email )
Change subject: Implement support for larger packet counter sizes ...................................................................... Patch Set 4: (5 comments) File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/507/comment/f254a2ce_f57578ee : PS3, Line 292: * big ending number in the wire format. > "endian"? Acknowledged File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/5002c984_e4c79e7d : PS3, Line 393: /* Combine IV from explicit part from packet and implicit part from context, > End on ". […] Done http://gerrit.openvpn.net/c/openvpn/+/507/comment/7c48e081_1bd56f08 : PS3, Line 394: * the length of the implicit length is initialised when the implicit is > That sentence is very unwieldy. […] Done File src/openvpn/dco.h: http://gerrit.openvpn.net/c/openvpn/+/507/comment/2852f4e6_e5ca91be : PS3, Line 253: * Return if the dco implementation supports the new protocol features of > "if" -> "whether" Done File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/7d199642_142d7abf : PS3, Line 3308: to.data_v3_features_supported = false; > I think you mean "to. […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2 Gerrit-Change-Number: 507 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 10:40:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
