Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email )
Change subject: crypto_backend: fix type of enc parameter ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: Thanks for introducing the typedef - this looks much cleaner, as Arne also suggested. However, I have a nit pick about the arg naming. File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/548/comment/f5ffc802_2b16c413 : PS3, Line 569: const char *ciphername, crypto_operation_t enc) may I argue that the name "operation" (or just "op") is more appropriate as this is not a bool (encrypt or not encrypt), but rather an enum being assigned some op? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/548?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If0dcdde30879fd6185efb2ad31399c1629c04d22 Gerrit-Change-Number: 548 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 13:24:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
