Attention is currently required from: flichtenheld, plaisthos. reynir has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/555?usp=email )
Change subject: Only schedule_exit() once ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/555/comment/3395ca91_15f2e5ca : PS1, Line 523: * only ever seems to be SIGTERM anyway. */ I also considered dropping the `signal` argument as it is currently always `SIGTERM` at all call sites. http://gerrit.openvpn.net/c/openvpn/+/555/comment/f2f84020_796d7125 : PS1, Line 530: event_timeout_init(&c->c2.scheduled_exit, n_seconds, now); I have only now thought of it: what if the new `n_seconds` is sooner than the already scheduled exit?! I suspect `n_seconds` is always 5, though. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661 Gerrit-Change-Number: 555 Gerrit-PatchSet: 1 Gerrit-Owner: reynir <rey...@reynir.dk> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: reynir <rey...@reynir.dk> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 22 Apr 2024 11:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
