Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/560?usp=email )
Change subject: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL ...................................................................... Patch Set 3: Code-Review-2 (1 comment) File tests/unit_tests/openvpn/test_crypto.c: http://gerrit.openvpn.net/c/openvpn/+/560/comment/365ef4c9_dafb7fea : PS3, Line 163: bool ret = ssl_tls1_PRF(seed, seed_len, secret, secret_len, out, sizeof(out)); This change causes build failures: ``` test_crypto.c: In function ‘crypto_test_tls_prf’: test_crypto.c:163:10: error: unused variable ‘ret’ [-Werror=unused-variable] 163 | bool ret = ssl_tls1_PRF(seed, seed_len, secret, secret_len, out, sizeof(out)); ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/560?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5bfa3630ad4dff2807705658bc877c4a429a39ce Gerrit-Change-Number: 560 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 30 Apr 2024 16:14:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
