Acked-by: Gert Doering <[email protected]>
Thanks for the patch, and the explanation on IRC. This is FreeBSD/DCO
specific, and makes the case
ifconfig ovpn3 create
openvpn --dev ovpn3 --dev-type tun --topology subnet ...
work correctly (without it, p2p ifconfig claims to work but ipv6 route
addition fails as well).
I have stared at the code (looks good) and tested on my FreeBSD 14/DCO
test VM with and without the patch, adding relevant test cases to the
t_client.rc setup. With the patch, nothing breaks ;-) and the newly
considered cases work.
There is a slight catch - if the interface (ovpn3) has already been
brought "up", the dco_set_ifmode() call fails with
2024-06-02 14:54:06 dco_set_ifmode: failed to set ifmode=00008002: Device
busy (errno=16)
.. so it will not work properly in all cases.
(Also, t_client.sh is not really suited for this sort of test today,
as the "compare pre/post ifconfig state" check fails on interface flags
- need to think more how to make this work)
The patch got badly whitespace mangled in transit (empty lines got
turned into extra indent in the following line, and thus). As I said
on IRC, I'm happy to fix that for occasional submitters, but generally
recommend "git send-email" or pushing to gerrit to avoid outlook induced
garbage.
Your patch has been applied to the master and release/2.6 branch
(highly localized, and arguably a bugfix).
commit 82036c17c45d45c3fe8725f64b33720cb9c94dad (master)
commit 2f2ff186564c3999efaf48d734df95471ac22d84 (release/2.6)
Author: Franco Fichtner
Date: Tue May 28 17:42:52 2024 +0000
Allow to set ifmode for existing DCO interfaces in FreeBSD
Signed-off-by: Franco Fichtner <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg28688.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
