Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/556?usp=email )
Change subject: configure: Try to detect LZO with pkg-config
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
close...
fbsd14, master + this patch, "configure" with no further arguments
```
checking for lzo2... yes
checking for lzo/lzoutil.h... no
checking for lzoutil.h... no
configure: error: lzoutil.h is missing
$ locate lzoutil.h
/usr/local/include/lzo/lzoutil.h
```
and this might actually be a broken `.pc`, as the failure is
```
configure:18961: result: no
configure:18969: checking for lzoutil.h
configure:18969: cc -c -g -O2 -std=c99 -I/usr/local/include/lzo conftest.c >&5
In file included from conftest.c:162:
/usr/local/include/lzo/lzoutil.h:33:10: fatal error: 'lzo/lzoconf.h' file not fo
und
#include <lzo/lzoconf.h>
^~~~~~~~~~~~~~~
```
so we *should* `-I/usr/local/include`.
On the other side, `lzoutil.h` has this comment
```
/***********************************************************************
// LZO-v1 deprecated macros (which were used in the old example programs)
//
// THIS FILE IS DEPRECATED. DO NOT USE.
************************************************************************/
```
so maybe we shouldn't check for this one at all? (we use `lzo_malloc()` and
`lzo_free()` though, but those are simple defines to plain malloc/free).
Mmmh.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee61fee74f26e693
Gerrit-Change-Number: 556
Gerrit-PatchSet: 6
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Sun, 02 Jun 2024 16:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
