Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/662?usp=email )
Change subject: Lay the foundation to support both old and new versions of DCO ...................................................................... Patch Set 1: (3 comments) File src/openvpn/dco_linux.h: http://gerrit.openvpn.net/c/openvpn/+/662/comment/86f99d7c_43678f20 : PS1, Line 129: * @param nl_msg the message to use > "The" Acknowledged http://gerrit.openvpn.net/c/openvpn/+/662/comment/88a96579_919aab40 : PS1, Line 174: * extended in the future if we need to lookup more than one mcast id. > "can be extended" ? Acknowledged File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/662/comment/2f02c26a_4ad35d7f : PS1, Line 1233: int cmd_del_peer = OVPN_CMD_DEL_PEER; > Why is this indirection required? Because with the next commit that will introduce support for dco_v3, the commands will be completely different (the names will be shared between dco_v3 linux and bsd while dco_v2 will use the *current* commands with the addition of the acronym v2 (i.e. OVPN_V2_CMD_GET_PEER) and since the commands that will be used will change based on the platform and the version of dco loaded, that differentiation must be made via #if defined -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/662?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6662605b60d4859949970cfe256c55cbcbd4a672 Gerrit-Change-Number: 662 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 27 Jun 2024 08:44:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
